Conversation
tt-cll
requested review from
0xAustinWang,
KodeyThomas,
agusaldasoro,
asoliman92,
chris-de-leon-cll,
mateusz-sekara and
winder
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves FeeQuoter destination-chain default configuration (and default destination gas price) out of user-supplied ChainDefinition literals and into chain-family adapters, with an optional override hook for per-lane tweaks.
Changes:
- Extend
LaneAdapterwithGetFeeQuoterDestChainConfig()andGetDefaultGasPrice()and populate these programmatically duringConnectChains. - Replace
ChainDefinition.FeeQuoterDestChainConfiginput withFeeQuoterDestChainConfigOverrides(functional option) and populateFeeQuoterDestChainConfiginternally. - Update integration tests / changeset tests and devenv helpers to rely on adapter defaults and optional overrides.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| integration-tests/deployment/update_to_FeeQuoter_2_0_test.go | Stops manually setting FeeQuoter dest-chain config in test chain definitions. |
| integration-tests/deployment/lane_migrator_test.go | Same as above for lane migrator test setup. |
| integration-tests/deployment/connect_chains_test.go | Adds override helper and updates assertions to use adapter-derived defaults + overrides. |
| devenv/common/implcommon.go | Removes manual default GasPrice/FQ config setup so ConnectChains can populate defaults. |
| deployment/utils/common.go | Factors hex decoding into GetHexFromString helper used by adapters. |
| deployment/lanes/product.go | Extends LaneAdapter interface with default config/gas price methods. |
| deployment/lanes/lane_update.go | Updates ChainDefinition to accept overrides and stores populated FeeQuoter dest config. |
| deployment/lanes/connect_chains.go | Populates defaults via adapter + applies overrides during address population. |
| chains/solana/deployment/v1_6_0/sequences/adapter.go | Implements new adapter default config/gas price methods for Solana. |
| chains/evm/deployment/v1_6_0/sequences/adapter.go | Implements new adapter default config/gas price methods for EVM. |
| chains/evm/deployment/v1_6_0/changesets/connect_chains_test.go | Updates expected config assertions to use adapter defaults. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
agusaldasoro
previously approved these changes
Mar 9, 2026
| GetFQAddress(ds datastore.DataStore, chainSelector uint64) ([]byte, error) | ||
| GetFeeQuoterDestChainConfig() FeeQuoterDestChainConfig | ||
| // GasPrice defines the USD price (18 decimals) per unit gas for this chain as a destination. | ||
| GetDefaultGasPrice() *big.Int |
Collaborator
There was a problem hiding this comment.
Nice, since you are adding this default gas price value, I'm also thinking about if we should provide the default token price as well. This because the existing evm add lane changeset will update the fq destChain config, but we used empty tokenPrice map in our changeset. Doesn't have to be in this PR, but worth adding to TODOs cc @krebernisak @nicolasgnr
Collaborator
Author
There was a problem hiding this comment.
yes I think we should
huangzhen1997
previously approved these changes
Mar 16, 2026
agusaldasoro
previously approved these changes
Mar 17, 2026
agusaldasoro
approved these changes
Mar 17, 2026
huangzhen1997
approved these changes
Mar 17, 2026
kylesmartin
approved these changes
Mar 17, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.